Feature: Add dead LiveViews section #798
Conversation
| @spec update_dead_liveviews_setting!(boolean()) :: {:ok, boolean()} | {:error, term()} | ||
| def update_dead_liveviews_setting!(new_value) when is_boolean(new_value) do |
There was a problem hiding this comment.
It feels weird to have ! and ok error tuple
| end | ||
|
|
||
| defp clear_tracing(socket) do | ||
| def clear_tracing(socket) do |
There was a problem hiding this comment.
Nitpick: private and public functions should be grouped together
There was a problem hiding this comment.
Shouldn't you handle DeadViewModeEntered event like you do in node_traces_live.ex?
| nil | ||
|
|
||
| {:ok, socket} -> | ||
| LvProcess.new(pid, socket) |
There was a problem hiding this comment.
| LvProcess.new(pid, socket) | |
| pid | |
| |> LvProcess.new(socket) |
| dead_lv_processes = | ||
| StatesStorage.get_all_states() | ||
| |> Enum.filter(fn {pid, %LvState{}} -> not Process.alive?(pid) end) | ||
| |> Enum.map(&elem(&1, 1)) | ||
| |> Enum.map(&(LvProcess.new(&1.pid, &1.socket) |> LvProcess.set_alive(false))) | ||
|
|
||
| {:ok, %{dead_grouped_lv_processes: LiveViewDiscovery.group_lv_processes(dead_lv_processes)}} |
There was a problem hiding this comment.
| dead_lv_processes = | |
| StatesStorage.get_all_states() | |
| |> Enum.filter(fn {pid, %LvState{}} -> not Process.alive?(pid) end) | |
| |> Enum.map(&elem(&1, 1)) | |
| |> Enum.map(&(LvProcess.new(&1.pid, &1.socket) |> LvProcess.set_alive(false))) | |
| {:ok, %{dead_grouped_lv_processes: LiveViewDiscovery.group_lv_processes(dead_lv_processes)}} | |
| dead_grouped_lv_processes = | |
| StatesStorage.get_all_states() | |
| |> Enum.filter(fn {pid, %LvState{}} -> not Process.alive?(pid) end) | |
| |> Enum.map(&elem(&1, 1)) | |
| |> Enum.map(&(LvProcess.new(&1.pid, &1.socket) |> LvProcess.set_alive(false))) | |
| |> LiveViewDiscovery.group_lv_processes() | |
| {:ok, %{dead_grouped_lv_processes: dead_grouped_lv_processes}} |
| LiveViews listed below are not active anymore and they will be removed in a short time (usually within 2 seconds). | ||
| If you want to keep them for a longer time you may do so by disabling | ||
| <b>Garbage Collection</b> | ||
| in <.link navigate={RoutesHelper.settings()} class="underline cursor-pointer">settings</.link>. But be aware that this will lead to increased memory usage. | ||
| <% else %> | ||
| You have <b>Garbage Collection</b> | ||
| disabled which means that LiveViews listed below will not be removed automatically. | ||
| This will lead to increased memory usage. You can enable it | ||
| in <.link navigate={RoutesHelper.settings()} class="underline cursor-pointer">settings</.link>. |
There was a problem hiding this comment.
Whole if expression is in <p> tag. You want me to add one more inside each expression case?
There was a problem hiding this comment.
I'd consider splitting dead and active liveviews section do LiveComponents
|
I'd also like to redesign it a bit - this is my proposition, but we can wait for the designs. I'd change the title to Dead LiveViews I wouldn't display Dead LiveViews at all with garbage collection enabled, since having LiveView displayed for 2s is not that helpful I think that the warning text is too long in both variants and we should probably use component similar to our flash but implementation for warning. Maybe you could decrease number of text by moving some stuff to tooltip Imo this color in warning is too gold(ish) - I'd change it to From left to right: Dead LiveViews inactive variant, variant with Garbage collection on, variant with garbage collection off |
3 participants
No description provided.