-
Notifications
You must be signed in to change notification settings - Fork 18
Enhancement: Improve Assigns section performance #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enhancement: Improve Assigns section performance #799
Conversation
f9ca243
to
4e004b5
Compare
In this PR an E2E test with search in assigns fails. Currently due to optimalization search in assigns doesn't work properly but I will fix it in other PR since this one is big enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐬 Amazing work 🐬
When assigns are really big the time required for render and update can take couple of seconds and It would be nice to have a loader indicating that the assigns are being updated
Also when testing on very big assigns html updates become increasingly longer but seems like it might be due to calculating assigns sizes (When I comment out displaying sizes it helps a lot). It's probably for another pr.
I think it is a good idea. What do you think about making gray overlay and not allowing user to interact when the UI is rendering? I would like to do i in separate PR since it's not crucial and some task are dependant on this one. ( #808 )
I've added sending big messages to dev to better show this case. I'll create task for running assigns size calculations in the background ( #807 ) |
No description provided.