Skip to content

Conversation

GuzekAlan
Copy link
Contributor

No description provided.

@GuzekAlan GuzekAlan force-pushed the 526-performance-issues-with-assigns-inspection-ver3 branch from f9ca243 to 4e004b5 Compare October 15, 2025 14:10
@GuzekAlan GuzekAlan marked this pull request as ready for review October 15, 2025 15:09
@GuzekAlan
Copy link
Contributor Author

In this PR an E2E test with search in assigns fails. Currently due to optimalization search in assigns doesn't work properly but I will fix it in other PR since this one is big enough

@GuzekAlan GuzekAlan requested review from hhubert6, kraleppa and srzeszut and removed request for hhubert6 and srzeszut October 15, 2025 15:19
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬 Amazing work 🐬

When assigns are really big the time required for render and update can take couple of seconds and It would be nice to have a loader indicating that the assigns are being updated

Also when testing on very big assigns html updates become increasingly longer but seems like it might be due to calculating assigns sizes (When I comment out displaying sizes it helps a lot). It's probably for another pr.

@GuzekAlan
Copy link
Contributor Author

GuzekAlan commented Oct 17, 2025

@hhubert6

When assigns are really big the time required for render and update can take couple of seconds and It would be nice to have a loader indicating that the assigns are being updated

I think it is a good idea. What do you think about making gray overlay and not allowing user to interact when the UI is rendering? I would like to do i in separate PR since it's not crucial and some task are dependant on this one. ( #808 )

Also when testing on very big assigns html updates become increasingly longer but seems like it might be due to calculating assigns sizes (When I comment out displaying sizes it helps a lot). It's probably for another pr.

I've added sending big messages to dev to better show this case. I'll create task for running assigns size calculations in the background ( #807 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants