Feature: trace diffs sent to browser #801
Open
+1,016
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuzekAlan
reviewed
Oct 17, 2025
| Enables tracing for a specific process. | ||
| """ | ||
| @spec process(pid(), flags :: list()) :: {:ok, term()} | {:error, term()} | ||
| def process(pid, flags) when is_list(flags) do |
There was a problem hiding this comment.
Nitpick: you could also add is_pid
| It stores the trace in table associated with `pid` given in `Trace` struct. | ||
| """ | ||
| @spec insert(Trace.t()) :: true | ||
| def insert(%Trace{} = trace) do |
There was a problem hiding this comment.
how about adding
defgaurd is_trace(trace) when is_struct(trace, Trace) or is_struct(trace, DiffTrace)| @type continuation() :: TracesStorage.continuation() | ||
| @type ets_table_id() :: TracesStorage.ets_table_id() | ||
| @type table_identifier() :: TracesStorage.table_identifier() | ||
| @type trace() :: Trace.t() | DiffTrace.t() |
There was a problem hiding this comment.
Why not use LiveDebugger.API.TracesStorage.trace() ?
| trace_diffs = Keyword.get(opts, :trace_diffs, false) | ||
|
|
||
| match_spec(node_id, functions, execution_times) | ||
| match_spec(node_id, functions, execution_times, trace_diffs) |
There was a problem hiding this comment.
Why not just do this
Suggested change
| match_spec(node_id, functions, execution_times, trace_diffs) | |
| match_spec(node_id, functions, execution_times) | |
| |> maybe_attach_diff_spec(trace_diffs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I introduced a new trace associated with LiveView diffs that are sent to the browser from LiveView via WebSocket. They can be accessed via global traces view, after selecting corresponding option in the filters form
Traces as a structure needs some unification, but since this PR is already big, I decided to refactor it in the next PR
Screen.Recording.2025-10-16.at.12.14.19.mov