Refactor model URL constants #382
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors URLs for models. This also exposed great inconsistencies in naming across hugging face repository:
llama3_2-3B_qat_lora.pte
there is-
between name and number of parameters, while for the rest is_
.WHISPER_TINY_DECODER
en
is concatenated in the first part of URL with.
and not with-
as in the rest of examples.all
inefficientnet_v2_s_coreml_all
and only for that model.-
and the model name as well -phi-4-mini
andphi-4-mini_bf16.pte
while in others there is-
and_
e.g.qwen-2.5
andqwen2_5_3b_8da4w.pte
.xnnpack_whisper_encoder.pte
and some on the end or almost end:style_transfer_udnie_xnnpack.pte
.ssdlite320-mobilenet-v3-large
v3 here is concatenated with-
but in model name not:ssdlite320-mobilenetv3-large.pte
.smolLm-2-135M
andsmolLm2_135M_bf16.pte
and for some not:qwen-2.5-1.5B
andqwen2_5_0_5b_8da4w.pte
.And there are even more, but you will spot them while correcting rest. I think that there is need to make this unified. And then I will be able to refactor this even more.
Type of change
Tested on
Testing instructions
No apply
Screenshots
No apply
Related issues
No apply
Checklist
Additional notes