Skip to content

Commit

Permalink
Bump fabric example to [email protected] (#3277)
Browse files Browse the repository at this point in the history
## Description

Bumping `FabricExample` app to `[email protected]` to test with
the next React Native version. I'll make all necessary changes to the
package in the following PR.
  • Loading branch information
jakex7 authored Dec 18, 2024
1 parent 5699860 commit 802af8a
Show file tree
Hide file tree
Showing 15 changed files with 1,146 additions and 1,254 deletions.
12 changes: 6 additions & 6 deletions FabricExample/__tests__/App-test.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from 'react';
import { it } from '@jest/globals';
import ReactTestRenderer from 'react-test-renderer';
import App from '../src/App';

// Note: test renderer must be required after react-native.
import renderer from 'react-test-renderer';

it('renders correctly', () => {
renderer.create(<App />);
test('renders correctly', async () => {
await ReactTestRenderer.act(() => {
ReactTestRenderer.create(<App />);
});
});
4 changes: 2 additions & 2 deletions FabricExample/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ buildscript {
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 34
ndkVersion = "26.1.10909125"
kotlinVersion = "1.9.24"
ndkVersion = "27.1.12297006"
kotlinVersion = "2.0.21"
isGHExampleApp = true
}
repositories {
Expand Down
227 changes: 4 additions & 223 deletions FabricExample/ios/FabricExample.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

6 changes: 0 additions & 6 deletions FabricExample/ios/FabricExample/AppDelegate.h

This file was deleted.

31 changes: 0 additions & 31 deletions FabricExample/ios/FabricExample/AppDelegate.mm

This file was deleted.

30 changes: 30 additions & 0 deletions FabricExample/ios/FabricExample/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import UIKit
import React
import React_RCTAppDelegate
import ReactAppDependencyProvider

@main
class AppDelegate: RCTAppDelegate {
override func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey : Any]? = nil) -> Bool {
self.moduleName = "FabricExample"
self.dependencyProvider = RCTAppDependencyProvider()

// You can add your custom initial props in the dictionary below.
// They will be passed down to the ViewController used by React Native.
self.initialProps = [:]

return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}

override func sourceURL(for bridge: RCTBridge) -> URL? {
self.bundleURL()
}

override func bundleURL() -> URL? {
#if DEBUG
RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
#else
Bundle.main.url(forResource: "main", withExtension: "jsbundle")
#endif
}
}
10 changes: 0 additions & 10 deletions FabricExample/ios/FabricExample/main.m

This file was deleted.

66 changes: 0 additions & 66 deletions FabricExample/ios/FabricExampleTests/FabricExampleTests.m

This file was deleted.

24 changes: 0 additions & 24 deletions FabricExample/ios/FabricExampleTests/Info.plist

This file was deleted.

7 changes: 1 addition & 6 deletions FabricExample/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,7 @@ target 'FabricExample' do
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/.."
)

target 'FabricExampleTests' do
inherit! :complete
# Pods for testing
end


post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
react_native_post_install(
Expand Down
Loading

0 comments on commit 802af8a

Please sign in to comment.