Open
Conversation
j-piasecki
reviewed
Jun 3, 2024
Comment on lines
42
to
45
| const firstPointerCoords = | ||
| tracker.getLastViewRelativeCoords(firstPointerID); | ||
| const secondPointerCoords = | ||
| tracker.getLastViewRelativeCoords(secondPointerID); |
Member
There was a problem hiding this comment.
Huh, does this actually work? In my head, when you try to calculate rotation based on points in the view coordinate space you would get jitter.
When you have two pointers on a view and you rotate them by some angle and then use that angle to rotate the view, that should cancel out. Essentially, the points would be constant in the coordinates of a view, even though they are different in the coordinates of the parent.
Or does transform simply not apply to the pointer/touch events sent by the browser?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On
web,anchorandfocalpoints are calculated with respect towindow, not the actual handlers'view. This PR changes this behavior so that both of these points are calculated correctly.Fixes #2929.
Test plan
Tested on example app and example from #2929
Test code