Remove deprecated components #3230
Conversation
|
There are still references to the removed components (like in |
My bad, I forgot these changes are merged into the fixed in ad0ff9c
fixed in b9cdf18 |
latekvo
force-pushed
the
@latekvo/remove-deprecated-components
branch
from
9aa72ba to
b9cdf18
Compare
| <Text style={styles.buttonText}> | ||
| Second info icon will block scrolling | ||
| </Text> | ||
| {/* Info icon will block interaction with other gesture handlers including | ||
| the scrollview handler its a descendant of. This is typical for buttons | ||
| embedded in a scrollable content on iOS. */} | ||
| <InfoButton disallowInterruption name="second" /> | ||
| </RectButton> | ||
| <View style={styles.buttonDelimiter} /> | ||
| <RectButton | ||
| style={styles.rectButton} | ||
| onPress={() => Alert.alert('Third row clicked')}> | ||
| <Text style={styles.buttonText}> | ||
| This one will cancel when you drag outside | ||
| </Text> | ||
| {/* Info icon will cancel when you drag your finger outside of its bounds and | ||
| then back unlike all the previous icons that would activate when you re-enter | ||
| their activation area. This is a typical bahaviour for android but less frequent | ||
| for most of the iOS native apps. */} | ||
| <InfoButton shouldCancelWhenOutside name="third" /> |
There was a problem hiding this comment.
Would it be possible to reimplement this using the new components? I'd like to keep something along these lines to make sure this behavior doesn't change accidentally.
There was a problem hiding this comment.
Of course, will do that
| </Animated.Text> | ||
| ); | ||
| } | ||
|
|
||
| export default function Example() { |
There was a problem hiding this comment.
If this is the yellowish looking one then I guess we can remove it entirely, no? It was supposed to compare both implementations visually and with one implementation gone it kinda lost its purpose.
There was a problem hiding this comment.
Right now it serves more as a test for the programatic swipeable controls, which encountered regressions several times since release.
I will move these tests to the other swipeable example, there's room for both of them
latekvo
force-pushed
the
@latekvo/remove-deprecated-components
branch
3 times, most recently
from
91a8d5d to
0a87e5e
Compare
Description
removes the following components:
DrawerLayoutSwipeableBetterHorizontalDrawerdraft componentSwipeabledraft componentThese components were also removed from all files referencing them,
such as examples, index files, and the
App.tsxof the common example appTest plan
mainbranch