Add error about functional components being used with old API #3240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Old API does not support functional components as it requires assigning
ref
to handler's child. If someone tries to pass functional component into handler, behavior differs based on platform:Web - app will crash in
GestureHandlerDelegate
:Cannot read properties of undefined (reading 'isButtonInConfig')
iOS - app won't crash, but the handler doesn't work anyway
This PR adds
error
that will be thrown when handler cannot obtain target view. This will unify behavior across platforms, as well as provide explanation of what went wrong.Test plan
Tested on the following code: