Update the generated specs for the old architecture to work on 0.77 #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
approved these changes
Dec 20, 2024
jakex7
added a commit
to software-mansion/react-native-svg
that referenced
this pull request
Jan 7, 2025
#2586) # Summary Similarly to software-mansion/react-native-gesture-handler#3301 we need to regenerate specs ## Test Plan CI should be green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3278 and #3277 added support for RN 0.77 where the result of generated java files has changed but those weren't updated in the PRs. This should've been caught by the CI but the
package.jsonfiles weren't listed as paths that would trigger it. This seems wrong, as I would imagine we would like the CI to run when changing dependencies, especially React Native.Test plan
Build the example app (0.75 old arch) and Fabric example app (0.77, both old and new arch)