Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependency #3323

Merged
merged 1 commit into from
Jan 10, 2025
+2 −1
Merged

Fix circular dependency #3323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Text.tsx
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,8 @@ import {
TextProps as RNTextProps,
} from 'react-native';

import { Gesture, GestureDetector } from '../';
import { GestureObjects as Gesture } from '../handlers/gestures/gestureObjects';
import { GestureDetector } from '../handlers/gestures/GestureDetector';

export const Text = forwardRef(
(props: RNTextProps, ref: ForwardedRef<RNText>) => {

Unchanged files with check annotations Beta

View file
src/RNGestureHandlerModule.web.ts
if (!(newView instanceof Element || newView instanceof React.Component)) {
shouldPreventDrop = true;
const handler = isNewWebImplementationEnabled()

Check warning on line 73 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe assignment of an `any` value
? NodeManager.getHandler(handlerTag)
: HammerNodeManager.getHandler(handlerTag);
const handlerName = handler.constructor.name;

Check warning on line 77 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe assignment of an `any` value

Check warning on line 77 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe member access .constructor on an `any` value
throw new Error(
`${handlerName} with tag ${handlerTag} received child that is not valid HTML element.`

Check warning on line 80 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Invalid type "any" of template literal expression
);
}
if (isNewWebImplementationEnabled()) {
// @ts-ignore Types should be HTMLElement or React.Component
NodeManager.getHandler(handlerTag).init(newView, propsRef);

Check warning on line 86 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe call of an `any` typed value
} else {
// @ts-ignore Types should be HTMLElement or React.Component
HammerNodeManager.getHandler(handlerTag).setView(newView, propsRef);

Check warning on line 89 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe member access .setView on an `any` value

Check warning on line 89 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe call of an `any` typed value
}
},
updateGestureHandler(handlerTag: number, newConfig: Config) {
newConfig
);
} else {
HammerNodeManager.getHandler(handlerTag).updateGestureConfig(newConfig);

Check warning on line 101 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe member access .updateGestureConfig on an `any` value

Check warning on line 101 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe call of an `any` typed value
}
},
getGestureHandlerNode(handlerTag: number) {
if (isNewWebImplementationEnabled()) {
return NodeManager.getHandler(handlerTag);
} else {
return HammerNodeManager.getHandler(handlerTag);

Check warning on line 108 in src/RNGestureHandlerModule.web.ts

GitHub Actions / check 

Unsafe return of an `any` typed value
}
},
dropGestureHandler(handlerTag: number) {