Update how handler configuration is handled on Android #3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
commented
Apr 11, 2025
|
|
||
| fun setMinNumberOfPointers(minNumberOfPointers: Int) = apply { | ||
| this.minNumberOfPointers = minNumberOfPointers | ||
| shouldCancelWhenOutside = DEFAULT_SHOULD_CANCEL_WHEN_OUTSIDE |
Member
Author
There was a problem hiding this comment.
It looks like shouldCancelWhenOutside was reset to false on every config update so the default in the initializer wasn't doing anything 🙈
j-piasecki
commented
Apr 11, 2025
| this.disallowInterruption = disallowInterruption | ||
| shouldActivateOnStart = DEFAULT_SHOULD_ACTIVATE_ON_START | ||
| disallowInterruption = DEFAULT_DISALLOW_INTERRUPTION | ||
| shouldCancelWhenOutside = DEFAULT_SHOULD_CANCEL_WHEN_OUTSIDE |
j-piasecki
commented
Apr 11, 2025
| numberOfPointersRequired = numberOfPointers | ||
| return this | ||
| maxDist = defaultMaxDist | ||
| shouldCancelWhenOutside = DEFAULT_SHOULD_CANCEL_WHEN_OUTSIDE |
m-bert
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All handler factories were stored in the
RNGestureHandlerModulewhich always seemed like an odd place to keep them in to me. This PR moves each factory to be a nested class of the relevant gesture handler. This gives us private access to the handler inside the factory, which in turn allows to get rid of the setter methods and assign directly instead. Those were with use since RNGH was written in java, but we have Kotlin now. It's time to let go and use proper syntax.It also adds default constants for each config property that didn't have it before.
Test plan
Example app