chore: Remove deprecated types from library and examples #7910
+30
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
approved these changes
Jul 25, 2025
|
This broke React Native Bottom Sheet, which uses Fix seems to be to use pr with fix: gorhom/react-native-bottom-sheet#2524 |
Member
Author
|
Hey @LinusU! These props were deprecated for a long time so we decided to finally remove them. Authors of other libraries should adapt to the new types. Thank you for opening the PR to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes types that are deprecated for a long time. We might have done that before the stable v4 release, but I think that there's nothing wrong to remove them in the
4.1.0.