feat(Worklets): runOnRuntimeSync
#8224
Open
+277
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Sep 11, 2025
| if (globalThis.__RUNTIME_KIND !== RuntimeKind.ReactNative) { | ||
| return WorkletsModule.runOnRuntimeSync( | ||
| workletRuntime, | ||
| makeShareableCloneOnUIRecursive(() => { |
There was a problem hiding this comment.
Why on worker runtime we want to call makeShareableCloneOnUIRecursive? 🤔
There was a problem hiding this comment.
This is an old name, it was created before the functionality of creating custom Worklet Runtimes was added. This function should be called makeShareableCloneOnWorkletRuntimeRecursive, but as we discussed yesterday with @tjzel, we will not change it
tjzel
requested changes
Sep 16, 2025
...ommon-app/src/apps/reanimated/examples/RuntimeTests/tests/runtimes/runOnRuntimeSync.test.tsx
Show resolved
Hide resolved
...ommon-app/src/apps/reanimated/examples/RuntimeTests/tests/runtimes/runOnRuntimeSync.test.tsx
Show resolved
Hide resolved
...ommon-app/src/apps/reanimated/examples/RuntimeTests/tests/runtimes/runOnRuntimeSync.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.h
Outdated
Show resolved
Hide resolved
packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.cpp
Outdated
Show resolved
Hide resolved
tjzel
approved these changes
Sep 24, 2025
Comment on lines
+7
to
+8
| `runOnRuntimeSync` lets you run a [workletized](/docs/fundamentals/glossary#to-workletize) function synchronously on a [Worker Runtime](/docs/fundamentals/glossary#worker-worklet-runtime---worker-runtime). | ||
| It might preempt the Runtime where it's called from the thread (it's blocking). |
There was a problem hiding this comment.
Suggested change
| `runOnRuntimeSync` lets you run a [workletized](/docs/fundamentals/glossary#to-workletize) function synchronously on a [Worker Runtime](/docs/fundamentals/glossary#worker-worklet-runtime---worker-runtime). | |
| It might preempt the Runtime where it's called from the thread (it's blocking). | |
| `runOnRuntimeSync` lets you run a [workletized](/docs/fundamentals/glossary#to-workletize) function synchronously on a [Worker Runtime](/docs/fundamentals/glossary#worker-worklet-runtime---worker-runtime). It's blocking - meaning that it can preempt the runtime from a thread that's currently executing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR :
runOnRuntimeSyncAPI functionrunOnRuntimeSynctype tests and runtime testrunOnRuntimeSyncfunctionTest plan