Use REACT_NATIVE_VERSION_MINOR provided by React Native instead of custom definition#8412
Draft
Use REACT_NATIVE_VERSION_MINOR provided by React Native instead of custom definition#8412
REACT_NATIVE_VERSION_MINOR provided by React Native instead of custom definition#8412Conversation
tjzel
approved these changes
Oct 20, 2025
Member
Author
|
TODO: fix macOS and tvOS builds |
piaskowyk
reviewed
Oct 20, 2025
| @@ -40,10 +39,6 @@ def find_config() | |||
| result[:is_reanimated_example_app] = ENV["IS_REANIMATED_EXAMPLE_APP"] != nil | |||
| result[:is_tvos_target] = react_native_json['name'] == 'react-native-tvos' | |||
| result[:react_native_version] = react_native_json['version'] | |||
Member
There was a problem hiding this comment.
Do we still need this part of the filer related to looking for the React Native location?
Member
Author
There was a problem hiding this comment.
Unfortunately yes, we still use config[:react_native_version] in validate-react-native-version.js.
Member
Author
|
0.81.1-3 is okay: https://github.com/react-native-tvos/react-native-tvos/blob/release-0.81.1-3/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h#L15-L17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses
REACT_NATIVE_VERSION_MINORandReactNativeVersion::Minoradded in facebook/react-native#48813 (available from 0.79) instead of a custom definitionREACT_NATIVE_MINOR_VERSIONas well as removes the minor version retrieval logic from build scripts on Android and iOS.Test plan