chore: Change CSS color representation from number or string to object #8414
+143
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
force-pushed
the
@matipl01/svg-brush-css-value
branch
from
34183be to
ef2ae7c
Compare
MatiPl01
force-pushed
the
@matipl01/css-colors-object-representation
branch
from
36afb32 to
6495352
Compare
MatiPl01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the format of the number passed to CPP used by CSS animations from a
numberor astring('currentColor','transparent') to an object with thecolorTypeproperty and the optional color value.It is necessary to allow implementing support for more color types in SVG CSS animations (they use more than just the
'currentColor'one) and it seems to be cleaner than an union of number or strings.