fix(types): make props optional when provided via animatedProps #8893
+169
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Warning
100% vibe coded. Let me know if you feel like this needs any human changes somewhere! So far from my tests this seems to work fine!
When using createAnimatedComponent with useAnimatedProps, props that are provided through animatedProps now become optional on the component itself.
This fixes the TypeScript error where required props would still be required on the component even when they were being provided via animatedProps.
Example:
Changes:
Test plan
I let the AI add test cases to verify this is working correctly.