fix(worklets): avoid HERMES_V1_ENABLED macro redefinition on RN 0.84+ #8908
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native 0.84 centralized the HERMES_V1_ENABLED define into
target_compile_reactnative_options() in react-native-flags.cmake.
When worklets also defines -DHERMES_V1_ENABLED=${HERMES_V1_ENABLED}
and then calls target_compile_reactnative_options(), the macro gets
defined twice with different values (true vs 1), causing:
error: 'HERMES_V1_ENABLED' macro redefined [-Werror,-Wmacro-redefined]
This fix only defines HERMES_V1_ENABLED manually for RN < 84.
kimchi-developer
force-pushed
the
fix/hermes-v1-macro-redefinition-rn84
branch
from
5b6b267 to
c4da159
Compare
Collaborator
|
Thanks for the PR, I can confirm that it works, just a bump to rc.4 is required in the repo. I'll make a PR. Could you confirm that nothing has to be done on iOS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
React Native 0.84 centralized the
HERMES_V1_ENABLEDdefine intotarget_compile_reactnative_options()inreact-native-flags.cmake(commit).When worklets defines
-DHERMES_V1_ENABLED=${HERMES_V1_ENABLED}and then callstarget_compile_reactnative_options(), the macro gets defined twice with different values (truevs1), causing:Requires
Solution
Only define
HERMES_V1_ENABLEDmanually for RN < 84, since RN 84+ handles it viatarget_compile_reactnative_options().Test plan