Skip to content

fix(worklets): avoid HERMES_V1_ENABLED macro redefinition on RN 0.84+ #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimchi-developer wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −3
Open

fix(worklets): avoid HERMES_V1_ENABLED macro redefinition on RN 0.84+ #8908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4da159
fix(worklets): avoid HERMES_V1_ENABLED macro redefinition on RN 0.84+
kimchi-developer Feb 3, 2026
803d7e9
chore: add QoL HermesV1 lines
tjzel Feb 3, 2026
9cf6264
Merge branch 'main' into fix/hermes-v1-macro-redefinition-rn84
tjzel Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/fabric-example/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,7 @@ enableWorkletsProfiling=true
# https://docs.gradle.org/current/userguide/configuration_cache.html
org.gradle.configuration-cache=true
org.gradle.configuration-cache.problems=fail

# Uncomment to enable HermesV1, requires additional steps
# https://reactnative.dev/blog/2025/10/08/react-native-0.82#how-to-enable-hermes-v1.
# hermesV1Enabled=true
2 changes: 2 additions & 0 deletions apps/fabric-example/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ require_relative '../../../packages/react-native-reanimated/scripts/clangd-add-x
ENV['IS_REANIMATED_EXAMPLE_APP'] = '1'
ENV['IS_REANIMATED_PROFILING'] = '1'
ENV['IS_WORKLETS_PROFILING'] = '1'
# Uncomment to enable HermesV1
# ENV['RCT_HERMES_V1_ENABLED'] = '1'

platform :ios, min_ios_version_supported
prepare_react_native_project!
Expand Down
2 changes: 1 addition & 1 deletion apps/fabric-example/ios/Podfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions packages/react-native-worklets/android/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@ string(
CMAKE_CXX_FLAGS
" -DREACT_NATIVE_MINOR_VERSION=${REACT_NATIVE_MINOR_VERSION}\
-DWORKLETS_VERSION=${WORKLETS_VERSION}\
-DWORKLETS_FEATURE_FLAGS=\"${WORKLETS_FEATURE_FLAGS}\"\
-DHERMES_V1_ENABLED=${HERMES_V1_ENABLED}")
-DWORKLETS_FEATURE_FLAGS=\"${WORKLETS_FEATURE_FLAGS}\"")

# HERMES_V1_ENABLED is centralized in react-native-flags.cmake for RN >= 84
# Only define manually for older versions to avoid macro redefinition error
if(REACT_NATIVE_MINOR_VERSION LESS 84)
string(APPEND CMAKE_CXX_FLAGS " -DHERMES_V1_ENABLED=${HERMES_V1_ENABLED}")
endif()

string(APPEND CMAKE_CXX_FLAGS " -fno-omit-frame-pointer -fstack-protector-all")

Expand Down
Loading