Fix bundle mode on windows #8910
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metro passes absolute paths to the moduleId factory. This means that on Windows, the worklet subpath check failed, so worklets didn't end up getting the expected moduleId, resulting in a crash in the hermes VM. Still not sure why this resulted in a crash instead of a runtime error, but this at least fixes this in this use case by normalizing the path prior to the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metro passes absolute paths to the moduleId factory. This means that on Windows (where
\is used as a path separator), the worklet subpath check (which expects a/separator) failed, so worklets didn't end up getting the expected moduleId, resulting in a crash in the hermes VM.Still not sure why this resulted in a crash instead of a runtime error (possibly broke some assumption in native bundle mode code?), but this at least fixes this in this use case by normalizing the path prior to the check.