Skip to content

Temporarily disable braavos integration #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 325 commits into from
Apr 10, 2025
Merged

Temporarily disable braavos integration #1583

merged 325 commits into from
Apr 10, 2025

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Apr 6, 2025 •
edited
Loading

Closes #1581

Introduced changes

Temporarily disable integration with braavos accounts, described in #1582

  • This PR contains breaking changes

@franciszekjob
Fix devnet installation action - use devnet_sha input
22192f8
@franciszekjob
Trgigger CI
44fe1ff
@franciszekjob
Remove install_devnet.yml workflow
d45b63e
@franciszekjob
Add todo in checks.yml
480862c
@franciszekjob
Remove temporary step for showing dirs
1c56dcf
@franciszekjob
Move parsed_abi_v2 into test_event_serialization_v2
90877d4
@franciszekjob
Fix formatting
1bffab1
@franciszekjob
Add echo for displaying contracts v2 directory contents
54da25a
@franciszekjob
Fix displaying contents of contracts v2 directory
9e8e356
@franciszekjob
Temporary change for displaying directory contents
1431174
@franciszekjob
Temporarily list contract v2 directory
4c3bbf0
@franciszekjob
Temporarily display owd
2ad7fe7
@franciszekjob
Revert "Temporarily display owd"
a71dc33 
This reverts commit 2ad7fe7.
@franciszekjob
Include Python 3.9 in Setup Tests job
cd64e4b
@franciszekjob
Remove CI changes apart from modified devnet installation
a081bd0
@franciszekjob
Temporarily display directory with compiled contracts
53945e8
@franciszekjob
Fix ls
c9af96a
@franciszekjob
Fix ls
25df9be
@franciszekjob
Unconditionally compile contracts v1 and v2
34dddd4
@franciszekjob
Use asdf action
9e353c2
@franciszekjob
Implement test_get_transaction_status_with_failure_reason; Code cle…
09503e1 
…anup
@franciszekjob
Fix linting; Tests cleanup
b72068d
@franciszekjob
Update regex in test_rejection_reason_in_transaction_receipt
b78fe68
@franciszekjob
Skip test_compute_deploy_account_v3_transaction_hash
43c303c
@franciszekjob
Format
97ccdef
@franciszekjob
Skip test_block_with_receipts_latest
6e2ccc7
@franciszekjob
Fix failing docs tests
424e122
@franciszekjob
Fix linting
a0f3671
@franciszekjob
Remove contracts conditional compilation on CI
993508b
@franciszekjob
Add contracts compilation steps in docs tests
bd09a44
Base automatically changed from franciszekjob/1498-4-websockets-docs to development April 8, 2025 16:19
ddoktorski
ddoktorski reviewed Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to check if the returned error contains INVALID_TX and only then verify if the sender account is braavos in order to display an informative message?

@franciszekjob franciszekjob changed the base branch from development to restore-gas-amount-multiplier-params April 9, 2025 23:06
@franciszekjob
Copy link
Collaborator Author

Wouldn't it be better to check if the returned error contains INVALID_TX and only then verify if the sender account is braavos in order to display an informative message?

Makes sense, applied the change.

Base automatically changed from restore-gas-amount-multiplier-params to development April 10, 2025 12:24
@franciszekjob franciszekjob merged commit bdc374a into development Apr 10, 2025
10 checks passed
@franciszekjob franciszekjob deleted the 1581-improve-devx-for-braavos-broken-accounts branch April 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees

@franciszekjob franciszekjob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better DevX for Braavos broken accounts
2 participants
@franciszekjob @ddoktorski