Add UI SQS message send/list/delete features#1140
Open
tuliocll wants to merge 4 commits intosoftwaremill:masterfrom
Open
Add UI SQS message send/list/delete features#1140tuliocll wants to merge 4 commits intosoftwaremill:masterfrom
tuliocll wants to merge 4 commits intosoftwaremill:masterfrom
Conversation
- Centralize message fetching to prevent component remounting - Implement message deletion with SQS API integration - Add HTML entity decoding for message display - Include comprehensive tests and performance optimizations - Update component architecture for
tuliocll
changed the title
afternoon2
requested changes
Aug 5, 2025
…tions - Replaced `notistack` with a custom Snackbar context for better control over notifications. - Simplified the QueueMessagesList component by removing unnecessary useMemo hooks and directly using utility functions for formatting and truncating text. - Updated QueueRow and QueueRowDetails components to streamline props and improve readability. - Enhanced error handling in message deletion and fetching functions with a centralized error message utility. - Added unit tests for new Snackbar context and refactored QueueService tests to align with the new structure. - Introduced utility functions for decoding HTML entities, formatting dates, and truncating text. - Cleaned up unused dependencies and ensured consistent code style across components.
Author
|
Thanks for the review — sorry for the many changes! |
afternoon2
requested changes
Aug 6, 2025
This commit includes: - Created decodeHtml utility function to handle HTML entity decoding - Added comprehensive unit tests for the decodeHtml utility - Created test utility module for consistent rendering with SnackbarProvider - Refactored component interfaces and nested functions to improve code structure - Updated test files to use shared renderWithSnackbarProvider utility - Applied HTML entity decoding to message display in QueueMessagesList - Fixed error message translation and improved code organization
Author
|
Apologies for the late update — I’ve made the requested changes now. |
|
Any chance this can be reviewed, @afternoon2 ? This would be very useful for the project I'm working on. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys, I want to contribute with these features that help me a lot with this awesome software!
I created three new features that make working with SQS messages much easier: