Version sorting #1045
Merged
Version sorting #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrect version resolution when multiple versions are returned from Sonatype Central and Maven Central APIs. Previously, the service would fail to correctly identify the latest version due to: 1. Array access bug: accessing sorted.docs[0] instead of sorted[0] 2. Inconsistent test mocks between Maven Central and Sonatype Central 3. Missing proper Maven semantic version comparison Changes: - Extract ComparableVersion class to dedicated module with proper Maven version ordering - Fix version array access after sorting in solrsearch.ts - Update test mocks to match actual API request URLs - Implement proper Maven version comparison (alpha < beta < rc < release < sp) - Use kebab-case naming convention for new files Closes #1009 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add CLAUDE.md with comprehensive development rules and technical specifications - Include testing guidelines, code change procedures, and debugging instructions - Document Maven version comparison logic and API specifications - Add file naming conventions (kebab-case for consistency) - Update .gitignore to exclude .claude folder from version control 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
lukaszlenart
force-pushed
the
fix/version-sorting
branch
from
1b61435 to
4470828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1009