Skip to content

MPT-9677 Termination order processing for finops extension #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

bdjilka
Copy link
Contributor

@bdjilka bdjilka commented May 5, 2025

No description provided.

@d3rky d3rky requested review from ffaraone and ruben-sebrango May 5, 2025 18:29
Copy link
Collaborator

@d3rky d3rky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also disable draft validation for Termination Orders. No need to fail it now

@bdjilka bdjilka requested a review from d3rky May 5, 2025 19:32
Copy link

@antoniodimariano antoniodimariano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

):
order = validate_order(mpt_client, processing_purchase_order)

assert order["error"] is None

order = validate_order(mpt_client, processing_termination_order)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please, parametrize it?

@d3rky d3rky force-pushed the MPT-9677-Termination-Order-for-FE branch from 21f51c4 to 9579333 Compare May 6, 2025 10:13
Copy link

sonarqubecloud bot commented May 6, 2025

@d3rky d3rky merged commit 30dbcd0 into main May 6, 2025
3 checks passed
@d3rky d3rky deleted the MPT-9677-Termination-Order-for-FE branch May 12, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants