feat: Improve the cloud account pagination to work with python filters (MPT-8485) #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbalabanov
commented
Jun 4, 2025
Comment on lines
+9
to
+16
| import optscale_client.config_client.client | ||
| from jira_bus.jira_bus_server.constants import backend_urls | ||
| from jira_bus.jira_bus_server.handlers.v2.app_descriptor import AppDescriptorHandler | ||
| from jira_bus.jira_bus_server.handlers.v2.app_descriptor import \ | ||
| AppDescriptorHandler | ||
| from jira_bus.jira_bus_server.handlers.v2.app_hook import ( | ||
| AppHookIssueUpdatedHandler, | ||
| AppHookIssueDeletedHandler, | ||
| ) | ||
| from jira_bus.jira_bus_server.handlers.v2.app_lifecycle import ( | ||
| AppLifecycleInstalledHandler, | ||
| ) | ||
| AppHookIssueDeletedHandler, AppHookIssueUpdatedHandler) | ||
| from jira_bus.jira_bus_server.handlers.v2.app_lifecycle import \ | ||
| AppLifecycleInstalledHandler |
There was a problem hiding this comment.
Ignore these changes, only formatting has changed and I haven't configured my editor yet to follow the project's patterns -- will fix this before making it public of course
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the cloud account pagination to work with python filters. Let's first discuss the implementation and see if there are any flaws -- if we're happy I'll apply it to the employees endpoint (and others if needed).
I initially tried to do it all at once since the implementation is generic enough but this proved to be trickier than I thought -- I fix one thing and another breaks, so decided to draw the line here for the initial review and not waste too much time in case it doesn't work
Related issue number
MPT-8485
Checklist