MPT-11279 vadalidate the parameters introduced by the customer #470
+863
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alephsur
requested review from
d3rky,
ruben-sebrango and
albertsola
as code owners
alephsur
force-pushed
the
MPT-11279-validate-the-parameters-introduced-by-the-customer
branch
2 times, most recently
from
40981fc to
e27e1e5
Compare
albertsola
approved these changes
Jul 23, 2025
alephsur
force-pushed
the
MPT-11279-validate-the-parameters-introduced-by-the-customer
branch
4 times, most recently
from
99373bc to
989b1b9
Compare
svazquezco
reviewed
Jul 25, 2025
adobe_vipm/flows/utils/parameter.py
Outdated
Comment on lines
89
to
110
| def set_params_visibility(params, hidden): | ||
| for param in params: | ||
| if hidden: | ||
| updated = set_parameter_hidden | ||
| else: | ||
| updated = set_parameter_visible | ||
| nonlocal updated_order | ||
| updated_order = updated(updated_order, param) | ||
|
|
||
| if agreement_value == "New": | ||
| set_params_visibility(PARAM_NEW_CUSTOMER_PARAMETERS, hidden=False) | ||
| set_params_visibility( | ||
| TRANSFER_CUSTOMER_PARAMETERS + (Param.MEMBERSHIP_ID,), | ||
| hidden=True | ||
| ) | ||
| elif agreement_value == "Migrate": | ||
| set_params_visibility( | ||
| PARAM_NEW_CUSTOMER_PARAMETERS + TRANSFER_CUSTOMER_PARAMETERS, | ||
| hidden=True | ||
| ) | ||
| set_params_visibility([Param.MEMBERSHIP_ID], hidden=False) | ||
| elif agreement_value == "Transfer": | ||
| set_params_visibility(PARAM_NEW_CUSTOMER_PARAMETERS, hidden=True) | ||
| set_params_visibility([Param.MEMBERSHIP_ID], hidden=True) | ||
| set_params_visibility(TRANSFER_CUSTOMER_PARAMETERS, hidden=False) | ||
|
|
||
| return updated_order |
There was a problem hiding this comment.
I feel this logic a bit complicated and I'm not a big fan of using nonlocal unless if there is a really good reason for it. I believe we could use a map and then call the set_parameter_hidden and set_parameter_visible. Something like:
param_map = {
"new": {
"visible": PARAM_NEW_CUSTOMER_PARAMETERS,
"hidden": TRANSFER_CUSTOMER_PARAMETERS + (Param.MEMBERSHIP_ID,),
},
"Migrate": {
"visible": [Param.MEMBERSHIP_ID],
"hidden": PARAM_NEW_CUSTOMER_PARAMETERS + TRANSFER_CUSTOMER_PARAMETERS,
},
...
}
update_order = set_parameter_visible(update_order, param_map[agreement_value] # I assume all the values have both visible and hidden params ,otherwise we can use an if conditional before with a get
update_order = set_parameter_hidden(update_order, param_map[agreement_value]
return updated_order
989b1b9 to
6ce6d86
Compare
svazquezco
reviewed
Jul 25, 2025
| from adobe_vipm.flows.constants import ( | ||
| PARAM_REQUIRED_CUSTOMER_ORDER, | ||
| Param, | ||
| ) |
There was a problem hiding this comment.
I'm a bit confused with this change and the one on line 63. Are they a Ruff change?
alephsur
force-pushed
the
MPT-11279-validate-the-parameters-introduced-by-the-customer
branch
4 times, most recently
from
c8d8f56 to
bd3f7eb
Compare
alephsur
force-pushed
the
MPT-11279-validate-the-parameters-introduced-by-the-customer
branch
from
bd3f7eb to
a08483d
Compare
|
ruben-sebrango
approved these changes
Jul 30, 2025
alephsur
deleted the
MPT-11279-validate-the-parameters-introduced-by-the-customer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.