Skip to content

fix#414 #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 14, 2024
Merged

fix#414 #415

merged 15 commits into from
Aug 14, 2024

Conversation

naohanpen
Copy link
Contributor

  • ファイル一覧の保持方法を変更
  • 選択され次第アップロード

@naohanpen
fix#414
82b2f25 
- ファイル一覧の保持方法を変更
- 選択され次第アップロード
@naohanpen naohanpen self-assigned this Jul 17, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2024 •
edited
Loading

Deploying sos24-client with  Cloudflare Pages  Cloudflare Pages

Latest commit: 33254bf
Status: ✅  Deploy successful!
Preview URL: https://030b630d.sos24-client.pages.dev
Branch Preview URL: https://fix--414.sos24-client.pages.dev

View logs

@appare45
Copy link
Member

npm ciがこけてるけどなんでだろう

@naohanpen
Copy link
Contributor Author

設定とかは何も変えていないはずなのですが、、💦

@arata-nvm
Copy link
Member

npm/cli#7657
これっぽそう

appare45
appare45 requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@appare45 appare45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装ありがとうございます！
確認お願いします

@appare45 appare45 added the 保留 保留 label Jul 24, 2024
@naohanpen naohanpen requested a review from appare45 July 27, 2024 08:05
@appare45
Copy link
Member

#424 とかなりコンフリクトしていそう

@appare45 appare45 mentioned this pull request Jul 28, 2024
Closed
appare45
appare45 requested changes Jul 28, 2024
View reviewed changes
Copy link
Member

@appare45 appare45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本当にお疲れ様＆ありがとうございます！
いくつかコメントしたので確認お願いします

@appare45 appare45 removed the 保留 保留 label Jul 28, 2024
@naohanpen
Copy link
Contributor Author

naohanpen commented Aug 4, 2024 •
edited
Loading

全然うまくいってなかった💦

  • 申請作成時にファイルを添付できない
  • 回答がないのに、回答が存在するという（申請詳細ページでは問題ないが、申請編集ページではエラーになる）
    • そもそも API 側での制限はあるので、編集ボタンの表示・非表示だけすればいいのか

@naohanpen
Copy link
Contributor Author

オブジェクトストレージのダウンにより保留中...

@naohanpen
Copy link
Contributor Author

naohanpen commented Aug 9, 2024 •
edited
Loading

  • ファイルのアップロードに失敗しているのに、完了しましたトーストが表示される（エラーが適切に投げられていない）

@naohanpen naohanpen requested a review from appare45 August 9, 2024 23:28
appare45
appare45 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@appare45 appare45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝

@appare45 appare45 merged commit 1e5f232 into develop Aug 14, 2024
4 checks passed
@appare45 appare45 deleted the fix-#414 branch August 14, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appare45 appare45 appare45 approved these changes

@WhatACotton WhatACotton Awaiting requested review from WhatACotton

Assignees

@naohanpen naohanpen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naohanpen @appare45 @arata-nvm