Skip to content

[672] 企画詳細画面のエラーハンドリング不備 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

[672] 企画詳細画面のエラーハンドリング不備 #673

merged 1 commit into from
Jun 15, 2025

Conversation

naohanpen
Copy link
Contributor

@naohanpen naohanpen commented Jun 14, 2025 •
edited
Loading

  • 企画詳細画面で申請一覧の取得に失敗しても、ページ自体は表示するように変更

fix #672

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 3.59% 511 / 14211
🔵 Statements 3.59% 511 / 14211
🔵 Functions 38.87% 131 / 337
🔵 Branches 59.81% 189 / 316
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/app/committee/projects/[project_id]/page.tsx 0% 0% 0% 0% 1-171
Generated in workflow #1312 for commit 062ba25 by the Vitest Coverage Report Action

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying sos25-client with  Cloudflare Pages  Cloudflare Pages

Latest commit: 062ba25
Status: ✅  Deploy successful!
Preview URL: https://36e717d6.sos25-client.pages.dev
Branch Preview URL: https://fix-672.sos25-client.pages.dev

View logs

@naohanpen naohanpen self-assigned this Jun 14, 2025
@naohanpen naohanpen added バグ 技術的な問題 P-medium labels Jun 14, 2025
reversed-R
reversed-R approved these changes Jun 15, 2025
View reviewed changes
Copy link
Contributor

@reversed-R reversed-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

Nitoryu008
Nitoryu008 approved these changes Jun 15, 2025
View reviewed changes
Copy link
Contributor

@Nitoryu008 Nitoryu008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naohanpen naohanpen merged commit 0ae817b into develop Jun 15, 2025
5 checks passed
@naohanpen naohanpen deleted the fix#672 branch June 15, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitoryu008 Nitoryu008 Nitoryu008 approved these changes

@reversed-R reversed-R reversed-R approved these changes

Assignees

@naohanpen naohanpen

Labels
P-medium バグ 技術的な問題
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

企画詳細画面のエラーハンドリング不備
3 participants
@naohanpen @Nitoryu008 @reversed-R