Skip to content

fix:場所未定の表示を「未定」に統一 #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

Conversation

nAgI314
Copy link
Contributor

@nAgI314 nAgI314 commented Jun 20, 2025

「??」は前の部分がnullまたはundefinedの時に後ろの値を返すため、空文字列の時はそのまま表示されてしまっていました。
undefined,null,空文字列は真理値を見るとすべてfalseを返すので、そちらで判断するように変更しました。

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 3.59% 511 / 14211
🔵 Statements 3.59% 511 / 14211
🔵 Functions 38.87% 131 / 337
🔵 Branches 59.81% 189 / 316
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/app/committee/projects/ProjectsList.tsx 0% 0% 0% 0% 1-223
src/common_components/project/ProjectView.tsx 0% 0% 0% 0% 1-223
Generated in workflow #1325 for commit 833e4d3 by the Vitest Coverage Report Action

Copy link
Contributor

@naohanpen naohanpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mikio815 mikio815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@naohanpen
Copy link
Contributor

@mikio815 approve して〜

@naohanpen naohanpen merged commit 21c6e70 into develop Jun 21, 2025
5 checks passed
@naohanpen naohanpen deleted the fix#651 branch June 21, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants