Skip to content

申請画面で企画番号と企画名が見えるように #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2025

Conversation

minethin
Copy link
Contributor

No description provided.

@minethin minethin requested a review from nishimotoac July 11, 2025 10:34
Copy link

github-actions bot commented Jul 11, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 3.58% 511 / 14273
🔵 Statements 3.58% 511 / 14273
🔵 Functions 38.87% 131 / 337
🔵 Branches 59.81% 189 / 316
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/app/committee/form-answers/[answer_id]/page.tsx 0% 0% 0% 0% 1-36
src/app/forms/[form_id]/page.tsx 0% 0% 0% 0% 1-47
src/common_components/form_answer/FormPage.tsx 0% 100% 100% 0% 2-170
Generated in workflow #1476 for commit a8bad6d by the Vitest Coverage Report Action

@nishimotoac
Copy link
Contributor

@letasuu
見た目変えた方がいいかなと個人的に思ってるんですけどどう思いますか

@letasuu
Copy link

letasuu commented Jul 14, 2025

@nishimotoac
現状がどうなっているかの確認方法を知らなくてちょっとなんとも言えないです...申し訳ない
ここかdiscordでイメージを見せていただけるとありがたいです

@nishimotoac
Copy link
Contributor

@nishimotoac 現状がどうなっているかの確認方法を知らなくてちょっとなんとも言えないです...申し訳ない ここかdiscordでイメージを見せていただけるとありがたいです

image こんな感じです!

@letasuu
Copy link

letasuu commented Jul 14, 2025

確かに変えたほうが見やすそうですね...
行列入れ替えて
企画番号 | 企画名
○○○ | ○○○○○
という形にしたほうが良い気もします
あと、わざわざ2行にしなくても企画番号と企画名というラベルが一目見ればわかるのならなくてもいいと思います☝

Copy link
Contributor

@nishimotoac nishimotoac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デザインの変更をお願いしたいです…🙇
上記のコメントを参考にしてもらえれば!

@minethin
Copy link
Contributor Author

了解しました👍

@minethin
Copy link
Contributor Author

image image

@nishimotoac こんな感じでどうでしょうか

@nishimotoac
Copy link
Contributor

かなりいいと思います!
@letasuu 上下どちらがいいとかその他意見ありますか?

Copy link

Deploying sos25-client with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8bad6d
Status: ✅  Deploy successful!
Preview URL: https://5df18c14.sos25-client.pages.dev
Branch Preview URL: https://feature-show-project-id-on-f.sos25-client.pages.dev

View logs

@naohanpen naohanpen requested a review from nishimotoac August 3, 2025 22:23
@@ -55,6 +56,9 @@ export const FormPage = ({ answer, answerError, answerLoading, form, formError,

const [editable, setEdiatable] = useState(false);

const { data: projectRes } = useSWR(answer?.project_id ? `/projects/${answer.project_id}` : null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

112行目で!Loadingと書く用にdataだけじゃなくてLoadingがあった方がいいかもしれないと思ったのですが、動きが問題なさそうなのでコメントを残すだけ残しておきます(直さなくてもいいと思います)

Copy link
Contributor

@nishimotoac nishimotoac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@nishimotoac nishimotoac merged commit 000b9cb into develop Aug 4, 2025
5 checks passed
@nishimotoac nishimotoac deleted the feature/show-project-id-on-form branch August 4, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants