Skip to content

Re #640 Add an upper bound on crypton#642

Merged
mpilgrem merged 1 commit intomainfrom
fixCrypton
Mar 7, 2026
Merged

Re #640 Add an upper bound on crypton#642
mpilgrem merged 1 commit intomainfrom
fixCrypton

Conversation

@mpilgrem
Copy link
Collaborator

@mpilgrem mpilgrem commented Mar 7, 2026

See:

The immediate problem is that direct dependency http-client-tls <= 0.3.6.4 does not support newly-released crypton-1.1.0 (an indirect dependency of hpack) but does not, itself, specify an upper bound on crypton.

@mpilgrem mpilgrem requested a review from sol March 7, 2026 10:58
Copy link
Owner

@sol sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this fixes the build this is fine with me.

@sol
Copy link
Owner

sol commented Mar 7, 2026

I guess we also need corresponding Hackage revisions. I think you already have the appropriate permissions. Do you wanna take care of this as well?

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Mar 7, 2026

@sol, for the hpack-0.39.* packages on Hackage with a crypton dependency, I have edited the Cabal file to specify crypton < 1.1. hpack-0.39.2 did not have a direct dependency on crypton, so a Cabal file revision is not possible.

@mpilgrem mpilgrem merged commit 09d66a3 into main Mar 7, 2026
9 checks passed
@mpilgrem mpilgrem deleted the fixCrypton branch March 7, 2026 21:40
@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Mar 7, 2026

@sol, the CI is green but the publish job fails (I think because indexed-traversable-0.1.4 does not yet recognise that it supports GHC 9.14.1/base-4.22.0.0). Should I release manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants