Skip to content

Conversation

Fake-User
Copy link
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description

Docs describe styles from imported CSS Files as being scoped to the component. This is not the current behavior. Imported styles are added to the document head and are global.

Related issues & labels

Docs described styles imported into a component as being scoped to the component. This is not the current behavior. Imported styles become global without the use of CSS modules or other dependencies.
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit d95f9e3
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/68f341ab11dd3b0008162e00
😎 Deploy Preview https://deploy-preview-1305--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. the CSS is added per-route, but the classes aren't scoped.

Thanks!

@atilafassina atilafassina merged commit 2997ee3 into solidjs:main Oct 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Content]: Guide claims styles are scoped when imported

2 participants