-
Notifications
You must be signed in to change notification settings - Fork 330
content: Expand notes on preloading data #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
8602320
to
4a50173
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR expands the documentation on data preloading in Solid Router, explaining how preloading works both within and outside SolidStart applications. It provides clarity on when and why to use manual preloading versus automatic preloading behavior.
- Added comprehensive documentation on automatic vs manual preloading behaviors
- Enhanced API documentation for
usePreloadRoute
with detailed type signatures - Clarified preloading mechanics with user actions and timing heuristics
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
use-preload-route.mdx |
Enhanced with usage examples, type signatures, and parameter documentation |
preloading.mdx |
New comprehensive guide on preloading concepts and advanced usage patterns |
data.json |
Added preloading guide to advanced concepts navigation |
routing-and-navigation.mdx |
Minor formatting improvements to code blocks with titles |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/routes/solid-router/reference/primitives/use-preload-route.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Let's expand on how preload works in Solid-Router within or outside a SolidStart app.
usePreloadroute
exists if that's the default behavior