Skip to content

Conversation

atilafassina
Copy link
Member

@atilafassina atilafassina commented Oct 18, 2025

Let's expand on how preload works in Solid-Router within or outside a SolidStart app.

  • Clarify why usePreloadroute exists if that's the default behavior
  • Clarify the advanced usage with deeply nested Lazy components
  • Clarify the mechanics/heuristics of how the Router decides to preload/prefetch components and data

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit e640128
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/68f5f4ef60a0a000084fa388

@atilafassina atilafassina self-assigned this Oct 18, 2025
@atilafassina atilafassina added solid-router Related to Solid Router solidstart Related to SolidStart labels Oct 18, 2025
@atilafassina atilafassina marked this pull request as ready for review October 18, 2025 16:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the documentation on data preloading in Solid Router, explaining how preloading works both within and outside SolidStart applications. It provides clarity on when and why to use manual preloading versus automatic preloading behavior.

  • Added comprehensive documentation on automatic vs manual preloading behaviors
  • Enhanced API documentation for usePreloadRoute with detailed type signatures
  • Clarified preloading mechanics with user actions and timing heuristics

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
use-preload-route.mdx Enhanced with usage examples, type signatures, and parameter documentation
preloading.mdx New comprehensive guide on preloading concepts and advanced usage patterns
data.json Added preloading guide to advanced concepts navigation
routing-and-navigation.mdx Minor formatting improvements to code blocks with titles

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@atilafassina atilafassina changed the title Preload data content: Expand notes on preloading data Oct 18, 2025
@atilafassina atilafassina requested a review from Copilot October 20, 2025 08:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solid-router Related to Solid Router solidstart Related to SolidStart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant