Skip to content

Conversation

@atilafassina
Copy link
Member

This better clarifies how to change rendering mode per route, in the configuration, and what would be the use-cases for each mode.

@atilafassina atilafassina requested a review from Copilot October 20, 2025 16:35
@atilafassina atilafassina self-assigned this Oct 20, 2025
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the SolidStart documentation by expanding the explanation of rendering modes (sync, async, and stream). It clarifies how to configure rendering modes globally and per-route, and provides guidance on when to use each mode.

  • Adds a comprehensive new page explaining rendering modes with use cases and feature comparisons
  • Updates configuration and server entry point references to link to the new rendering modes documentation
  • Adds mode parameter documentation to the config reference

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/routes/solid-start/building-your-application/rendering-modes.mdx New comprehensive guide explaining the three rendering modes, their features, and configuration options
src/routes/solid-start/building-your-application/data.json Adds the new rendering modes page to the navigation
src/routes/solid-start/reference/server/create-handler.mdx Updated to reference the new rendering modes page and improved type signature documentation
src/routes/solid-start/reference/entrypoints/entry-server.mdx Simplified with references to the new rendering modes documentation
src/routes/solid-start/reference/config/define-config.mdx Added mode parameter documentation and formatting improvements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

atilafassina and others added 5 commits October 20, 2025 18:37
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
@atilafassina atilafassina marked this pull request as ready for review October 20, 2025 16:38
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit c83f957
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/68f664d54d382500088bdeea
😎 Deploy Preview https://deploy-preview-1308--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 10eafa5
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6922be66360e3500084d1630

@atilafassina atilafassina enabled auto-merge (squash) October 21, 2025 07:28
@atilafassina atilafassina added the solidstart Related to SolidStart label Oct 21, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- Data-fetching: client-side only, first load will render Suspense fallbacks.
- Time To First Byte (TTFB): fast since the server-side rendering is minimal.
- Total page load time: slower since the client-side rendering is heavier.
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'to render the page' is repeated. Remove the first occurrence to read: 'Uses renderToString from Solid's core to render the page synchronously.'

Suggested change
- Total page load time: slower since the client-side rendering is heavier.
Uses [`renderToString`](/reference/rendering/render-to-string) from Solid's core to render the page synchronously.

Copilot uses AI. Check for mistakes.
@atilafassina atilafassina requested a review from Copilot October 26, 2025 18:43
kodiakhq bot added 30 commits October 27, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solidstart Related to SolidStart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants