Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(translation): Add spanish UI translations #762

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

royeden
Copy link
Contributor

@royeden royeden commented Jun 1, 2024

Adds generic spanish translations. Generic implies that spanish speakers will understand them, regardless of their regional variant.

This should provide a base for future spanish translations, where regional variants have different words to refer to different concepts (in case that is needed).

  • Comment regarding code: If english is the default, and the keys have to match, it could be good to match the type of translation dictionaries to match the keys in the english dictionary.

  • Notes on translations:

{
        // This reads like UIs with no effort, with reactive precision. The comma could be ommited.
	"hero.title": "UIs sin esfuerzo, con precisión reactiva.", 
	
	 // Could be a more informal "Empezar ahora"
	"hero.button.primary": "Comenzar ahora",
	
	// This could also be translated as "Derivación de valores", meaning "Value derivation", 
	"main.nav.section.derived.values": "Valores derivados",
	
	 // This is a known colloquial translation for "routing", known as an "americanism" to refer to the "correct" term: "Enrutado".
	 // I've never personally seen "Enrutado" being used in a technological project / education.
	"main.nav.section.routing": "Ruteo",

        // This is another known colloquial translation derived from "render"
	"main.nav.section.rendering": "Renderizado",

        // I feel like translating stores might be a bit cumbersome, due to it being a specific API in the project
	"main.nav.section.stores": "Stores",

        // Same thing with `Solid-Router`.
	"main.nav.section.solid.router": "Solid-Router",
	
	// Reads like "functions for loading"
	"main.nav.section.solid.router.load.functions": "Funciones de carga",
}

Copy link

stackblitz bot commented Jun 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 9a39517
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/66cbbce993460800083be1ad
😎 Deploy Preview https://deploy-preview-762--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes added the pending review Awaiting review by team members. label Jun 11, 2024
src/i18n/dictionaries/es/ui.ts Outdated Show resolved Hide resolved
@titoBouzout titoBouzout added the i18n Anything to do with internationalization & translation. label Sep 22, 2024
@titoBouzout
Copy link
Collaborator

@royeden Thanks Roy for the update!

I've asked around, and would like to inform you why this has been appearing to take a bit of time. The docs site was made with translations/localizations in mind, but then it was restructured to include SolidStart, SolidRouter and SolidMeta. This caused mayor changes to the localizations' logic, such switching languages between pages of the different subprojects and the like. It's on the works but will require some time to get it done as it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation. pending review Awaiting review by team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants