Fix seroval 1.3.0 compat #2474
Merged
Fix seroval 1.3.0 compat #2474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to fix package versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
I haven't updated the lockfile because Solid is currently locked to PNPM 9, I'm using PNPM 10.
This PR fixes a potential incompatibility with Seroval 1.3.0 (latest release) which reworks the serialized status/value of a serialized Promise. The change was imminent because it made Seroval incompatible for use in the React ecosystem (due to React's internal suspense mechanism which relies coincidentally with the
statusproperty)