fix regression: reading props.is
causes Dynamic
component to re-render
#2530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems like reading
props.is
forcreateElement
was causing theDynamic
component to re-render. I've cached it in the same way as thecomponent
prop. Introduced by #2514How did you test this change?
Tested by splicing the fix in the generated code of one of the reproducible bug reports.
Related:
kobaltedev/kobalte#619
https://discord.com/channels/722131463138705510/1404584263755759707
https://discord.gg/solidjs