Skip to content

Commit 8a6f2cc

Browse files
forkatabenjaminwil
andcommitted
Update Tailwind executable call for v3.0
`solidus_starter_frontend` provides templates including the `tailwindcss-rails` gem without any version constraints. So when 3.0 was released this week, it broke CI runs for the Solidus repository. It appears that the only breaking change is related to the `.executable` call. As of `tailwindcss-rails` `>= 3.0` the command for the executable was extracted to a separate `tailwindcss-ruby` gem, which causes an error in the rake tasks we generate for the `solidus_admin`. The error this fixes is: NoMethodError: undefined method `executable' for Tailwindcss::Commands:Module Co-authored-by: benjamin wil <[email protected]>
1 parent c3fea3e commit 8a6f2cc

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ end
5151

5252
group :admin do
5353
gem 'solidus_admin', path: 'admin', require: false
54-
gem 'tailwindcss-rails', '~> 2.0', require: false
54+
gem 'tailwindcss-rails', '~> 3.0', require: false
5555
gem 'axe-core-rspec', '~> 4.8', require: false
5656
gem 'axe-core-capybara', '~> 4.8', require: false
5757
end

admin/lib/solidus_admin/install_tailwindcss.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
namespace :solidus_admin do
4040
namespace :tailwindcss do
4141
root = Rails.root
42-
tailwindcss = Tailwindcss::Commands.executable
42+
tailwindcss = Tailwindcss::Ruby.executable
4343
4444
tailwindcss_command = [
4545
tailwindcss,

admin/lib/solidus_admin/testing_support/dummy_app/rake_tasks.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
DummyApp::Application.root.join("app/assets/stylesheets/solidus_admin/application.tailwind.css")
3434
)
3535

36-
tailwindcss = Tailwindcss::Commands.executable
36+
tailwindcss = Tailwindcss::Ruby.executable
3737

3838
tailwindcss_command = [
3939
tailwindcss,

0 commit comments

Comments
 (0)