[Admin] feature specs fixes #5253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those gems are required by solidus_admin in order to work. This issue was blocking dummy app from loading properly the JavaScript code, while host application were working because had those gems added to their gemfile during the installation.
Not having this would generate an error during feature specs.
github-actions
bot
added
the
changelog:repository
kennyadsl
approved these changes
Jul 17, 2023
| @@ -1,6 +1,7 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="<%= current_locale %>"> | |||
| <head> | |||
| <%= favicon_link_tag 'favicon.ico' %> | |||
There was a problem hiding this comment.
What is the error here, just for the sake of curiosity? Something related to a11y?
There was a problem hiding this comment.
No, not accessibility, it's just capybara complaining for the 500 received when trying to fetch the default /favicon.ico.
Codecov Report
@@ Coverage Diff @@
## nebulab/admin #5253 +/- ##
==============================================
Coverage 88.41% 88.42%
==============================================
Files 596 596
Lines 14464 14466 +2
==============================================
+ Hits 12789 12791 +2
Misses 1675 1675
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
added
changelog:solidus_admin
and removed
changelog:repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes will help make feature specs work and properly load JS when driving a selenium browser.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: