Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add "Add Product" button #5263

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Jul 20, 2023

Summary

Result image
ui/button now can be rendered as a link image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jul 20, 2023
@elia elia changed the base branch from main to nebulab/admin July 20, 2023 15:45
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 20, 2023
@elia elia changed the title [Admin] Add product button [Admin] Add "Add Product" button Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5263 (f0d5cb7) into nebulab/admin (785fd63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           nebulab/admin    #5263   +/-   ##
==============================================
  Coverage          88.46%   88.47%           
==============================================
  Files                596      596           
  Lines              14508    14510    +2     
==============================================
+ Hits               12835    12837    +2     
  Misses              1673     1673           
Impacted Files Coverage Δ
...mponents/solidus_admin/products/index/component.rb 87.50% <100.00%> (+0.54%) ⬆️
...pp/components/solidus_admin/ui/button/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review July 20, 2023 17:37
@elia elia requested a review from a team as a code owner July 20, 2023 17:37
<h1 class="body-title">
<%= Spree::Product.model_name.human.pluralize %>
</h1>

<div class="ml-auto">
<%= render component("ui/button").new(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rebase on top of #5254?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the products/index component @waiting-for-dev 👍

@rainerdema rainerdema merged commit ff433bb into nebulab/admin Jul 21, 2023
@rainerdema rainerdema deleted the elia/admin/add-product branch July 21, 2023 09:55
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants