[Admin] Make account navigation accessible #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make the user name a button so it can be focused and activated by the keyboard. We also render it before the links in the DOM so the next tab will focus on the first link. We close the dropdown when the focus leaves the last item.
We use the corresponding `aria` attributes to tell screen readers that there's an expandable menu.
github-actions
bot
added
the
changelog:repository
elia
added
changelog:solidus_admin
and removed
changelog:repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We make it browsable by keyboard. We transform the user name to button so it can be focused and activated by the keyboard. We also render it before the links in the DOM so the next tab will focus on the first link. We close the dropdown when the focus leaves the last item.
We also make it more friendly for screen readers by using the
aria-expandedattribute to tell screen readers if the menu is expanded or not.
screencast-localhost_3000-2023.07.21-08_59_43.webm
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: