Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Mark the current link in the main nav for accessibility #5273

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[Admin] Mark the current link in the main nav for accessibility #5273

merged 1 commit into from
Jul 21, 2023

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Jul 21, 2023 •
edited
Loading

Summary

By using the aria-current attribute we can mark the current link in the main nav as active for screen readers.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev
Mark the current admin link in the main mav for accessibility
1fdb091 
By using the `aria-current` attribute [1] we can mark the current link
in the main nav as active for screen readers.

[1] https://w3c.github.io/aria/#aria-current
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner July 21, 2023 13:27
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 21, 2023
@waiting-for-dev waiting-for-dev self-assigned this Jul 21, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Jul 21, 2023
@kennyadsl kennyadsl changed the title [Admin] Mark the current link in the main mav for accessibility [Admin] Mark the current link in the main nav for accessibility Jul 21, 2023
kennyadsl
kennyadsl approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waiting-for-dev waiting-for-dev merged commit a47969d into solidusio:nebulab/admin Jul 21, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/current_page branch July 21, 2023 13:45
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@elia elia Awaiting requested review from elia

@rainerdema rainerdema Awaiting requested review from rainerdema

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @kennyadsl @elia