Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Armenian language translations for Select2 plugin #5285

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add Armenian language translations for Select2 plugin #5285

merged 1 commit into from
Aug 9, 2023

Conversation

arman-h
Copy link
Contributor

@arman-h arman-h commented Jul 27, 2023

Summary

Adding Armenian language translations for Select2 plugin.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@arman-h arman-h requested a review from a team as a code owner July 27, 2023 08:47
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Jul 27, 2023
@arman-h arman-h changed the title add Armenian language translations for Select2 plugin Add Armenian language translations for Select2 plugin Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #5285 (c50c521) into main (8864b2a) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c50c521 differs from pull request most recent head d919458. Consider uploading reports for the commit d919458 to get more accurate results

@@            Coverage Diff             @@
##             main    #5285      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.01%     
==========================================
  Files         563      563              
  Lines       13890    13889       -1     
==========================================
- Hits        12322    12320       -2     
- Misses       1568     1569       +1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the help of ChatGPT, this looks correct. Thanks!

@kennyadsl
Copy link
Member

@arman-h may I also ask you to squash all commits into a single one?

@waiting-for-dev
Copy link
Contributor

Thanks, @arman-h! As suggested, could you please squash all commits before we merge it? 🙏

@waiting-for-dev waiting-for-dev merged commit 25cc48e into solidusio:main Aug 9, 2023
4 checks passed
@Julian-Dumitrascu
Copy link

The discussion is more complex than this; we require more than one thing. I mention this one: We're choosing software for building a marketplace in the Romanian language. With whom would you like me to communicate about this?

@kennyadsl
Copy link
Member

Hey @Julian-Dumitrascu, if you want, I'm available for guidance in exploring Solidus. You can find me in our Slack.

@Julian-Dumitrascu
Copy link

Slack.

I've been using it since 13 April 2014. It hasn't convinced me, although I appreciate that team's work. Among the issues: I thought I'd give it another try. What their team has to say: "We’re experiencing issues"
While they can sort those out, we can choose more reliable software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants