Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving solidus_sample to be development dependency #5591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

softr8
Copy link
Contributor

@softr8 softr8 commented Jan 9, 2024

Summary

Solidus Sample gem includes seed data to setup local development in an easy way, it includes catalogs for countries, states, products, taxonomies/taxons and images. This gem itself needs about 10mb of disk space and most of the times it is only needed in local development or one time.

Example

~ $ du -a /app/vendor/bundle/ruby/2.7.0/gems/ 2>/dev/null | sort -n -r | head -n 100
363848	/app/vendor/bundle/ruby/2.7.0/gems/
...
9696	/app/vendor/bundle/ruby/2.7.0/gems/solidus_sample-2.11.15
9648	/app/vendor/bundle/ruby/2.7.0/gems/solidus_sample-2.11.15/db
9640	/app/vendor/bundle/ruby/2.7.0/gems/solidus_sample-2.11.15/db/samples

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@softr8 softr8 requested a review from a team as a code owner January 9, 2024 14:43
@github-actions github-actions bot added the changelog:solidus Changes to the solidus meta-gem label Jan 9, 2024
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea!

Could you please move the dependency to the main Gemfile and also change the core install_generator so that it will add it to the host application Gemfile (with group: :development)?

@softr8 softr8 force-pushed the ecruz/remove-prod-dependency branch from 259d199 to 7358f20 Compare January 10, 2024 21:34
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Jan 10, 2024
Solidus Sample gem includes seed data to setup local development in
an easy way, it includes catalogs for countries, states, products,
taxonomies/taxons and images. This gem itself needs about 10mb of disk
space and most of the times it is only needed in local development
or one time.
@softr8 softr8 force-pushed the ecruz/remove-prod-dependency branch from 7358f20 to 6eb253e Compare January 11, 2024 14:24
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.65%. Comparing base (64f6a58) to head (6eb253e).
Report is 1139 commits behind head on main.

Files with missing lines Patch % Lines
...ib/generators/solidus/install/install_generator.rb 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5591      +/-   ##
==========================================
- Coverage   88.66%   88.65%   -0.02%     
==========================================
  Files         683      683              
  Lines       16293    16296       +3     
==========================================
+ Hits        14446    14447       +1     
- Misses       1847     1849       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good idea. Do you mind to update the PR?

@tvdeyen tvdeyen added the type:enhancement Proposed or newly added feature label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants