-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving solidus_sample to be development dependency #5591
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea!
Could you please move the dependency to the main Gemfile and also change the core install_generator
so that it will add it to the host application Gemfile (with group: :development
)?
259d199
to
7358f20
Compare
Solidus Sample gem includes seed data to setup local development in an easy way, it includes catalogs for countries, states, products, taxonomies/taxons and images. This gem itself needs about 10mb of disk space and most of the times it is only needed in local development or one time.
7358f20
to
6eb253e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
==========================================
- Coverage 88.66% 88.65% -0.02%
==========================================
Files 683 683
Lines 16293 16296 +3
==========================================
+ Hits 14446 14447 +1
- Misses 1847 1849 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good idea. Do you mind to update the PR?
Summary
Solidus Sample gem includes seed data to setup local development in an easy way, it includes catalogs for countries, states, products, taxonomies/taxons and images. This gem itself needs about 10mb of disk space and most of the times it is only needed in local development or one time.
Example
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: