Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Rails 7.2 #5843

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Allow Rails 7.2 #5843

merged 9 commits into from
Nov 1, 2024

Commits on Oct 31, 2024

  1. Allow Rails 7.2 

    We need at least v3.7 of awesome_nested_set for Rails 7.2 support
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    83f76a4 View commit details
    Browse the repository at this point in the history

  2. Fix pending migration check for Rails 7.2 

    Rails 7.2 removed migration_context from ActiveRecord::Base.connection
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    36db12a View commit details
    Browse the repository at this point in the history

  3. Mark Dummy App's ApplicationRecord as abstract class 

    Without that ActiveRecord 7.2 expects a DB table
for it.
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    977ac53 View commit details
    Browse the repository at this point in the history

  4. Add Rails 7.2 to circle ci test matrix

    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a6e3a0a View commit details
    Browse the repository at this point in the history

  5. Use rails-7.2 branch of solidus_starter_frontend 

    This installs the master branch of canonical-rails.
Necessary for Rails 7.2 compatibility.
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bf1de64 View commit details
    Browse the repository at this point in the history

  6. CI: Bump solidus-installer cache key 

    We updated to Rails 7.2 and need to update the
cache version.
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    aab4eea View commit details
    Browse the repository at this point in the history

  7. Use positional arguments for defining enums 

    Rails 8.0 removes the option to remove keyword
arguments for defingin enums.
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f761108 View commit details
    Browse the repository at this point in the history

  8. Fix enum definition in TaxRate.rb 

    How has this ever worked this way?
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b4c03f2 View commit details
    Browse the repository at this point in the history

  9. Test: Give "Receive" button more time to render 

    This is a flaky test, so give Capybara it bit more time
to find the button.
    @tvdeyen
    tvdeyen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e0b78d0 View commit details
    Browse the repository at this point in the history