Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Line Item Actions to solidus_legacy_promotions #5916

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 13, 2024

Summary

This table belongs to the legacy promotion system and was, unfortunately, missed in the original extraction.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

This table belongs to the legacy promotion system and was,
unfortunately, missed in the original extraction.
@mamhoff mamhoff requested a review from a team as a code owner November 13, 2024 16:01
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (b1a3796) to head (d339e84).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5916      +/-   ##
==========================================
- Coverage   89.54%   89.54%   -0.01%     
==========================================
  Files         783      782       -1     
  Lines       17994    17988       -6     
==========================================
- Hits        16113    16107       -6     
  Misses       1881     1881              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! We cannot be sure that the migration has not already ran for folks. I think we should introduce a new migration file for this table

@tvdeyen tvdeyen added backport-v4.4 Backport this pull-request to v4.4 changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem labels Nov 14, 2024
@tvdeyen tvdeyen merged commit 79b0511 into solidusio:main Nov 14, 2024
20 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 going in the next patch level release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.4 Backport this pull-request to v4.4 changelog:solidus_core Changes to the solidus_core gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants