Backend Menu: Fix "Promotions" items #5921
Merged
+27
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
3 tasks
mamhoff
force-pushed
the
fix-solidus_promotions-menu_item
branch
2 times, most recently
from
6e789f8
to
a3e24eb
Compare
Prior to this commit, legacy promotions would be called "Promotions", but if `solidus_promotions` is installed, they would be called "Legacy Promotions" in the menu. It's much easier if each of the two promotion engines just inserts its own menu item into the menu, and the legacy promotion system is called "Legacy Promotions" from the get-go. Co-Authored-By: [email protected]
adammathys
approved these changes
Nov 14, 2024
mamhoff
force-pushed
the
fix-solidus_promotions-menu_item
branch
from
a3e24eb
to
6a7d839
Compare
tvdeyen
approved these changes
Nov 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5921 +/- ##
==========================================
- Coverage 89.54% 89.54% -0.01%
==========================================
Files 783 783
Lines 17994 17986 -8
==========================================
- Hits 16113 16105 -8
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, legacy promotions would be called "Promotions", but if
solidus_promotionsis installed, they would be called "Legacy Promotions" in the menu. It's much easier if each of the two promotion engines just inserts its own menu item into the menu, and the legacy promotion system is called "Legacy Promotions" from the get-go.