[Admin] Add product properties admin UI #5926
Draft
+137
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour is to use the plural version of the model human name, which is defined in core as "Property Types", however the navigation in the new admin has different nomenclature for this model. This change ensures we use the same language as the navigation for consistency.
Adds the `New` component and renders it on the page. It doesn't actually work yet! Co-authored-by: benjamin wil <[email protected]>
Previously this would force the development server to run on 3000, but it is useful to be able to override that. Co-authored-by: Harmony Evangelina <[email protected]>
This completes the ability to create a new product property in the new admin UI. Co-authored-by: Harmony Evangelina <[email protected]>
forkata
force-pushed
the
issues/5857/add-product-properties-admin
branch
from
b2ea1b7
to
7a8bbd6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5926 +/- ##
==========================================
- Coverage 89.53% 89.52% -0.02%
==========================================
Files 782 783 +1
Lines 17980 18015 +35
==========================================
+ Hits 16099 16128 +29
- Misses 1881 1887 +6 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Nov 15, 2024
| @@ -9,5 +9,5 @@ if ! test -d sandbox; then | |||
| bin/sandbox | |||
| fi | |||
|
|
|||
| export PORT=3000 | |||
| export PORT=${PORT:-3000} | |||
There was a problem hiding this comment.
Appreciate this change. Can this be extracted into a separate PR, so we can already use this (while this PR is developed) and it appears in the changelog?
|
Probably a rebuild of #5892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change addresses #5857 and introduces a new UI for creating and
editing product properties in the new admin.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: