Open
Conversation
tvdeyen
requested changes
Feb 7, 2017
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks!
Please rename the es-ES locale file back into es-ES.yml again and change the first key into es-ES
Also please remove the RuboCop commit from this PR and make a separate one for this particular change.
config/locales/es-ES.yml
Outdated
| @@ -0,0 +1,1338 @@ | |||
| es: | |||
Member
There was a problem hiding this comment.
Has to be es-ES: otherwise this locale is used for es instead.
|
|
||
| # Neatly aligned code is too swell. | ||
| Style/SingleSpaceBeforeFirstArg: | ||
| Style/SpaceBeforeFirstArg: |
Member
There was a problem hiding this comment.
This change does not belong into this PR. Could you please open a separate one?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: It not possible to distinguish between the diferent translations to spanish when chosing the locale inside the Admin settings. So it adds missing this_file_language values for the this_file_language keys. Tests are included.