Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamespage_details_subheader - margin fix #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kuax-Meat
Copy link

margin-bottom issues fix.

http://i.imgur.com/shRYPFe.jpg

@CaptainMagma
Copy link
Contributor

I think I edited the margin bottom to be a little larger a while ago so that the black background did not appear too small for games that only show 1 line of information. Even though the margin does not look very even for all cases, I thought it was a decent balance, so I'm not quite sure if this is needed. Have you tested how it looks with varying lines of text other than just the two in your picture (last played and hours played)?

@somini
Copy link
Owner

somini commented Apr 11, 2015

@CaptainMagma Is there any way of getting 3 lines in that textbox? I don't think I ever saw that happen.

Thanks for your contribution, @Kuax-Meat

@CaptainMagma
Copy link
Contributor

With the decreased height, this is how it looks with one line

With the height the way it is, the one line looks even, and anything with more looks a little taller.

@somini Yes, you can have 3 if you share your library. And I think you can have a max of 4 if you share a library and do in-home streaming as well.

@somini
Copy link
Owner

somini commented Apr 11, 2015

That's a conundrum then.
I just tested and the default skin optimizes for looking good with a single line too, just how it is right now, so I guess I'll keep it that way.
It's a matter of personal preference, really.

@somini somini self-assigned this Apr 11, 2015
@Kuax-Meat
Copy link
Author

just suggestion ;) never mind @CaptainMagma . i don't want to argue with you.

@CaptainMagma
Copy link
Contributor

I appreciate all suggestions and never mean to argue. I only meant to inform you of why it looks the way it does is all. Any other suggestions you have, I (and everyone else working on the skin) will always be open to.

@somini
Copy link
Owner

somini commented Apr 13, 2015

I second @CaptainMagma, no hard feelings. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants