Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sai-gen] Parse P4 metadata into SAI spec for lib generation. #576

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Jun 1, 2024

The current SAI spec has all the information for header generation. To simplify the lib generation as well, parse the SAI to P4 info mapping into SAI spec too.

This can simplify the SAI lib templates, as we don't have to do too many checks in the templates anymore.

@r12f
Copy link
Collaborator Author

r12f commented Jun 1, 2024

Hi @marian-pritsak check out the ca to pa spec! : D with this info, we should be able to fix the field id problem for good!

@r12f r12f requested a review from marian-pritsak June 2, 2024 01:50
@r12f r12f changed the title [sai-gen] Parse P4 metadata into SAI spec for lib generation [sai-gen] Parse P4 metadata into SAI spec for lib generation, Support SAI spec merging Jun 2, 2024
@r12f r12f changed the title [sai-gen] Parse P4 metadata into SAI spec for lib generation, Support SAI spec merging [sai-gen] Parse P4 metadata into SAI spec for lib generation and support SAI spec merging Jun 2, 2024
@r12f r12f changed the title [sai-gen] Parse P4 metadata into SAI spec for lib generation and support SAI spec merging [sai-gen] Parse P4 metadata into SAI spec for lib generation. Jun 2, 2024
@r12f
Copy link
Collaborator Author

r12f commented Jun 2, 2024

Splitted this change into 2: this one and #577 . Since this change is dependent on #577 , I am making this one a draft for now. Otherwise, this change will be too large to review.

@r12f r12f marked this pull request as draft June 2, 2024 02:08
@r12f r12f changed the title [sai-gen] Parse P4 metadata into SAI spec for lib generation. [sai-gen] Parse P4 metadata into SAI spec for lib generation. (Pending #577) Jun 2, 2024
@r12f r12f changed the title [sai-gen] Parse P4 metadata into SAI spec for lib generation. (Pending #577) [sai-gen] Parse P4 metadata into SAI spec for lib generation. Jun 18, 2024
@r12f r12f marked this pull request as ready for review June 18, 2024 06:11
@r12f r12f merged commit 26c9357 into sonic-net:main Jun 18, 2024
4 checks passed
@r12f r12f deleted the user/r12f/p4-meta branch June 18, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants